1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/chat.cpp

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/m on Thu Feb 2 13:48:00 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b56bf8edcf92494e56d410aa
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Sysop can chat with nodes that aren't logged-in (at logon prompt, new users)

    Be sure to let them select a node even when no nodes are technically "in use". As requested by Nelgin in IRC (what, no gitlab issue?)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Apr 17 11:38:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/44f626bbcd42e03864c73def
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Add source node number to sysop notification that they're being paged to chat

    Fix issue #551

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Fri Apr 28 23:58:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/62e2280e6e59c520eae9abb4
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    Fix buffer overflow in guru chat parsing engine

    The trigger was this line in the recent change to guru.dat:
    Unrealized potential. :-(

    That open paren was parsed as the beginning of a new guru expression. A very long guru expression that overflowed the stack variable 'str' here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sun Apr 30 15:20:17 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/5fd4f1ca4a66fa612d243c0b
    Modified Files:
    src/sbbs3/chat.cpp
    Log Message:
    A close-parenthesis in a guru.dat response string would throw-off the parser

    After a negative-match of a Guru expression, we were searching for the next
    '(' anywhere in the subsequent chars of the file rather than just the next
    line that started with an open-parenthesis character.

    This bug was the secondary cause of the buffer-overflow crash addresseed in commit 62e2280e which was triggered by my recent updates to the guru.dat.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net