• src/sbbs3/sbbsecho.c

    From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Thu Feb 16 00:01:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6fb20b919003c805a40c207c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Resolve signed/unsigned compare warning with MSVC

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/ccfad124e104b09bf825392e
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    More consistent 'exact' parameter values to findnodecfg() - e.g. false, not 0

    No functional change.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Feb 18 12:59:30 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/15b230af547ff5932c6073e5
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Rework NetMail routing logic to handle point destinations better

    With this commmit, the logic is now:

    If the NetMail destination is a point and there's no linked-node for it
    and the boss node for this point is not one of our AKAs
    then route to the boss node (no linked-node match needed)
    if the boss node matches a linked-node with a route configuration
    then route to that configured route destination (2-levels of routing
    and thus 2 "Routing NetMail" msgs will be logged in this scenario)

    If the NetMail destination is a point and there is a linked-node for it
    then the netmail will not be routed
    unless that linked node has a route configuration

    NetMail destined for non-points are treated the same as before this
    commit.

    No change in the routing of echomail for points.

    I think this change fixes issue #520 which can be traced back to commit 45ced2a3b for poindexter FORTRAN (REALITY), 2 years ago almost to the
    day, where that change added point->boss routing, but only if the boss
    had a matching linked-node configuration (for both echomail and
    netmail).

    This commit also re-thinks commit ffe69b43623d (for Alterego) which
    would not route a point netmail if any our local AKAs matched the
    destination address, igorining the point value. I think what was
    intended here (I coudln't locate the original enhancmenet request or
    issue), was to not route if a local AKA was the *boss* of the point.
    And with this commit, that's now how it now works.

    As before, "test results appreciated".

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From poindexter FORTRAN@VERT/REALITY to Rob Swindell (on ChromeOS) on Sat Feb 18 18:45:27 2023
    Re: src/sbbs3/sbbsecho.c
    By: Rob Swindell (on ChromeOS) to Git commit to main/sbbs/master on Sat Feb 18 2023 12:59 pm

    As before, "test results appreciated".

    Thanks for doing this. I'm relying on the nightlies, so I'll download them tomorrow and test.
    ---
    ■ Synchronet ■ .: realitycheckbbs.org :: scientia potentia est :.
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sat Apr 15 19:45:46 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/227e2f4986eb0b04c05cc6ea
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Stop classifying msgs for unknown areas as security violations

    When Secure EchoMail is enabled and a Bad Echo Area (*) is defined in the
    area file (areas.bbs), but the packet source address is *not* listed as a
    link to the Bad Echo Area (tag: *) in areas.bbs, any messages for unknown
    areas in such a packet would cause the pkt to be considered a bad packet
    with a security violation. Instead, the message should just be skipped.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b185201161cd35dea8273d84
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Strip the "in-transit" attribute flag from imported packed-messages

    Log a warning message when either the "local" or "in-transit" flag has been stripped from ("Sanitized") imported packed-messages.

    Keyop reported a chksmb warning on a FidoNet message that contained the 'in-transit' attribute:
    <Keyop> Message flagged as 'In Transit' (?): 1
    <Keyop> fidonet_fidosoft Message Base has Errors!

    The message in question appears just to be a corrupted echomail msg coming
    from HPT:
    Sender '56:43 '
    To Tommi Koivula
    Subject test
    X-FTN-AREA FIDOSOFT.HUSKY
    X-FTN-TID hpt/os2-wc 1.9.0-cur 2021-03-14

    SBBSecho didn't use to convert/import the "in-transit" flag on imported
    netmail or echomail messages, ... until commit 446ab0ef7e09e5c61cf, which
    was needed to support the TickFix robot. So now, let's just sanitize the packed-message attributes a little sooner in the import process and log a warning when such sanitization has taken place.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Tue May 30 17:27:04 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d6eadf369e7ed75248b1819c
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Truncate trailing whitespace from FidoNet message header fields

    It's unclear whether trailing whitespace is supposed to be significant or not (FidoNet specs don't say), but I don't see any reason why "John Doe" and
    "John Doe " should be considered unique senders or recipients. Remove any trailing whitespace from message subjects too.

    This change makes the trailing whitespace truncation in SMB hash functions unnecessary (at least for SBBSecho-imported messages), but most (all?) other message transports don't allow for this nonsense in the first place.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Jun 26 11:03:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/e76fafaae4580941b343253b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix type 2.2 packet header generation

    As reported by Deon on DOVE-Net: type 2.2 packet generation was not (since SBBSecho v3.0) setting the origin and destination point values correctly:
    was leaving the packet type 2.0 date values in these fields.

    Also, zero-out the reserved bytes in the type 2.2 packet header (don't leave the type 2.0 date values in there).

    Thanks for the report Deon!

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Jul 20 11:53:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/68df9812f31add3f94430d77
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Always delete the AREASxxxxxx temp file

    When there are no changes (areas added or removed) via an areafix message, the data/AREASxxxxxx temp file would be left behind. The file was only removed if areas were added or removed from the area file via areafix message.

    The orphaned data/AREASxxxxxxx files were reported via DOVE-Net by Gamgee (PALANTIR)
    If you have these stale files, you can safely delete them.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Sun Sep 17 23:27:45 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f9b0dda5a1cac371a50f9f3f
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Add more detail (e.g. line number) to various "error opening" log msgs

    Some of the errors could be pretty vague since they looked the same and
    we were depending on the path/file attempted to be opened in the log msg
    to clue us into what exactly was being attempted. But some of these file
    paths are sysop-configurable, and they can put unexpected things in there
    that make it difficult to determine exactly what file was trying to be
    opened and for what purpose. This should help a little bit.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 4 21:14:35 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/43fb687f2e138e183f841a42
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix issue when packing netmails for multiple different linked-nodes

    Introduced in commit 15b230af (9 months ago), the first linked-node config (including packet password!) for the first packed netmail message would be reused for subsequent packed netmail messages.

    Thank you to Wilfred van Velzen (2:280/464) for reporting this problem!

    Additional debug-level log message when using a packet password for a newly created packet.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 4 22:57:40 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/28e435bdc2e909f38032afd4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Combine the "new packet" and "password-protected" debug-log lines

    ... to de-clutter the log

    Also, don't log the packet passwords. Folks copy and post sbbsecho.log lines and that could seriously compromise the security of the Interwebs if those super-secret passwords were ever leaked!

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Dec 15 17:25:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fc9d641054b36d9a84cc87da
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/6e1118af6abf0c55ca608a29
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Don't use wildcard node packet password (if one exists)

    This also addresses the addresses with 65535 in them in the new debug-level
    log messages "New packet (type x) created for linked-node" .

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Dec 31 17:16:52 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c2f663c30ab71c7493babab4
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Log message attributes in human-readable form (not just hexadecimal)

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sun Jan 7 20:47:22 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/623613492036f9806c225436
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Expand sole-LFs in message text (shouldn't normally be there)

    Expanded to CRLF or just CR (if strip LFs is enabled).

    It is possible for someone to stuff LF-terminated text in a message, so let's account for that possibility upon export to FTNs where LFs are supposed to be ignored.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Deuc┬┐@VERT to Git commit to main/sbbs/master on Wed Feb 7 10:47:17 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/20aecd3a4d979af82e3f509b
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix more warnings...

    It looks like we may need a set of PRI?TIME macros for printf()ing
    a time_t.

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 16 20:11:36 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9b28769f4b669763409f0435
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Bugfix: actually use the SMB netattr 'HOLD' attribute flag

    ... when exporting from SMB to .msg ("stored message") file

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 16:12:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/4c7a908f8ee55161faf3be71
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Insure buf is null-terminated in getzpt(), resoving CID 488308

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Mar 23 17:13:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5a2a73ae1b20ddf3563c23fe
    Modified Files:
    src/sbbs3/sbbsecho.c
    Log Message:
    Fix typo in previous commit to this file

    ---
    ■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net