• src/sbbs3/bat_xfer.cpp

    From Rob Swindell (in GitKraken)@VERT to Git commit to main/sbbs/master on Thu Mar 2 18:56:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/5d1d586fd74709f9cd1a9fc3
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Better access enforcement to files in batch download queues

    If a file gets added to a batch download queue that a user doesn't have download-access to (at the time of batch download), deal with that gracefully and consistently.

    start_batch_download():
    - Now checks current user access to download the file in both single-file and batch modes
    - Now performs credit-check in single-file mode (wasn't doing so previously)
    - totalsize of multi-file batch download queue is now calculated again (apparently removed/broken in the new filebase conversion of v3.19), so download ETA should be calculated more accurately (?) again
    - Use gettimetodl() to calculate each file's download time for multi-file downloads
    - Using new putnode_download() method to write node downloading "action" and ETA-in-aux fields
    - The node status wasn't being updated at all before start of download in single-file mode - fixed

    create_batchdn_lst() :
    - Checks each file still downloadable by the user and if not, removes from the queue (and the generated list file).
    - Performs credit check and removes files that exceed available user credit
    - returns true only when 1 or more files is added to the batch download list file

    addtobatdl()
    - Removed redundant 'D' restriction check - this is handled by can_user_download() check already.
    - Use the 'reason' out parameter from can_user_download() to determine which error string to display (not always CantDownloadFromDir).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Mar 3 18:00:28 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/9a79d265b21f513e06c98907
    Modified Files:
    src/sbbs3/bat_xfer.cpp
    Log Message:
    Fix missing 'autohang' argument in call to protocol()

    Caught by a GCC warning.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net