https://gitlab.synchro.net/main/sbbs/-/commit/bba2a9d5f6426be4cec140f8 Modified Files:
src/sbbs3/prntfile.cpp
Log Message:
Don't print a CRLF in printfile() (called by menu) if no file exists
printfile() assumes you want the file displayed starting in column 0, so will send a CRLF to insure that it does (unless the P_NOCRLF mode flag is specified). But this CRLF printing was happening before the file was opened and when the P_NOERROR mode flag is specified, this should be a silent failure with no print output. So move the CRLF printing to *after* the file is opened.
This expose an issue in the latest xtrn_sec.js where it makes several calls to bbs.menu() with the P_NOERROR mode flag set, expecting nothing to happen if/when the optional display files (e.g. xtrn*_tail.*) don't exist.
Reported by JC via IRC.
I'm so tired of this 30 year old frequently asked question.
If a sysop really wants their Synchronet BBS to only work correctly for ANSI users, I suppose that should be their prerogative.
I always felt that by not detecting/displaying menu files when the minimum set of files was not present, I was helping sysops to identify an issue with their system (which would not work correctly for non-ANSI users). *And* I always felt that having a single menu/display file that correctly supported both ANSI and non-ANSI users was a nice convenience (who really wants to maintain multiple versions of their menu files?). But I'm so tired of answering this question, I just give up.
thanks for giving up.
Re: src/sbbs3/prntfile.cpp
By: MRO to Rob Swindell on Fri Mar 25 2022 05:31 am
thanks for giving up.
I feel for the dozens of PETSCII terminal users that might be impacted.
Oh well. :-)
Re: src/sbbs3/prntfile.cpp
By: Digital Man to MRO on Fri Mar 25 2022 12:35 pm
Re: src/sbbs3/prntfile.cpp
By: MRO to Rob Swindell on Fri Mar 25 2022 05:31 am
thanks for giving up.
I feel for the dozens of PETSCII terminal users that might be impacted. Oh well. :-)
maybe have it do a special entry in the log file.
Sysop: | Lmorchard |
---|---|
Location: | Portland, OR |
Users: | 58 |
Nodes: | 16 (0 / 16) |
Uptime: | 158:18:56 |
Calls: | 368 |
Files: | 1 |
Messages: | 22,357 |