1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/main.cpp

    From rswindell@VERT to CVS commit on Mon Apr 27 14:00:32 2020
    src/sbbs3 main.cpp 1.783 1.784
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv20792

    Modified Files:
    main.cpp
    Log Message:
    The "all nodes in use" message specifically said "telnet nodes". Change to "terminal nodes".


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sat May 23 12:11:07 2020
    src/sbbs3 main.cpp 1.789 1.790
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv533

    Modified Files:
    main.cpp
    Log Message:
    Address problem reported by wkitty42:
    May 21 00:00:15 southeaststar synchronet: evnt BBS Events Executing external: ?logonlist -m
    May 21 00:00:15 southeaststar synchronet: evnt BBS Events !JavaScript warning /sbbs/exec/load/nodedefs.js line 167: Disconnected
    ... by setting the online mode to ON_LOCAL while executing the sys_daily event.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun Jul 19 21:12:22 2020
    src/sbbs3 main.cpp 1.790 1.791
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv13583

    Modified Files:
    main.cpp
    Log Message:
    Don't display full path (just the filename) of errored JS file to user.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Aug 23 17:50:06 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/b105d77749607d5bc8dacc99
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower log level of the "Perhaps node is already runnnig" log msg from ERR to WARN

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Thu Sep 3 22:29:28 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/8bf25ec78bdcf404e0ddab27
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower the SSH-related log message severities to WARNING for SSH connections

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Sep 19 22:33:42 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9bf4b7bba19d951f3ca48c96
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't send telnet commands to spy sockets

    send_telnet_cmd() now sends telnet commands/replies directly to the client socket. This avoid the entire output_thread() teeing of sent data to spy sockets/buffers (which may not be Telnet at all).

    There are some concerns with this change:
    - if client_socket isn't writable, will sendsocket() block?
    - if output_thread is sending on the same socket, are our 2/3-byte telnet
    commands going to have other output data interleaved within? (seems very
    unlikely)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Sep 19 23:04:07 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/cbdb2b494c85d24a7b3b887b
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Move the "connect" spy message to where the hostname and IP address are known

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Fri Oct 23 01:51:57 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/ec6d7e3edf557779be7e54cd
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't count guest logins as authenticated connections...

    When enforcing the MaxConcurrentConnections limit, don't count connections for user's with blank passwords (i.e. Guest) as authenticated.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wed Nov 4 23:28:33 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/3a19853b763f35a22ece717c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Address 32-bit GCC warning about printf format

    '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'off_t

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Fri Nov 13 00:24:17 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/bd78d5c5725843afc6659822
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Add timestamp of node.log file to crash.log

    When a preexisting node.log file is found, a terminal server crash is suspected. Include the timestamp of the node.log in the message appended to the system log (data/logs/*.log) to help identify the likely time of the crash.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deon George@VERT to Git commit to sbbs/master on Sun Nov 22 00:35:59 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Ooops, forgot to make btox static

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deon George@VERT to Git commit to sbbs/master on Sun Nov 22 00:35:59 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/db690fadea6237739f73825c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Improve btox() so that it doesnt lead to any buffer overruns

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Digital Man@VERT to Deon George on Sun Nov 22 13:23:45 2020
    Re: src/sbbs3/main.cpp
    By: Deon George to Git commit to sbbs/master on Sun Nov 22 2020 12:35 am

    https://gitlab.synchro.net/sbbs/sbbs/-/commit/6d0ec492cd2a5db51e416548 Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Ooops, forgot to make btox static

    Oops, I forgot to squash this giant merge. <grimmace>
    --
    digital man

    Rush quote #64:
    He's cleaning up his systems to keep his nature pure .. New World Man
    Norco, CA WX: 75.9øF, 29.0% humidity, 6 mph NNE wind, 0.00 inches rain/24hrs ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Nov 29 00:31:28 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/82d3ae6e61d8876d35444bdf
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Load/keep/refresh each node's configuration in memory.

    Previously, all nodes shared the same copy of the configuration in memory. This prevented any node from seeing an updated configuration until all nodes were offline or waiting for connection and could be recycled. Now, no recycling of the server is needed for a node to load a new config. A node in-use *still* cannot reload configuration until the user disconnects, but all you have to do is logon to another unused node and you (or that user) will get an updated configuration. Bots or server recycling problems will no longer prevent the sysop or user from getting a current configuration when connecting to any node.

    This is one of those instances of giving the sysop what he wants rather than what he asked for. I should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Nov 29 11:40:10 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/827063bb1d4343e145a85ffa
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Copy event last-run info from global config into node config

    Fixes issue introduced in last commit to this file (the each-node-has-its-own-config-in-memory enhancement) that would prevent users from logging in because their time was reduced for an upcoming event that had already run. The change assumes the event thread is running (its the thing that reads the event last-run info from time.dab). Thanks to mlong for the report.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Nov 29 12:28:05 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/07bd3442362ada96e99a4294
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fallback to the "first node" configuration

    If a node's configuration can't be loaded (e.g. nodeX/node.cnf is missing), fall-back and load the "first node" (e.g. Node1) configuration. On recent *nix installs (since the migration to Git), the node2+/node.cnf files were not copied/created, so let's solve that soon-to-be-FAQ now.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Nov 29 13:10:58 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/656bdb8fe79786b94f7dc5ac
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log a warning when falling-back the loaded node configuration.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Bob Roberts@VERT/HOVAL to Rob Swindell on Sun Nov 29 12:45:15 2020
    Re: src/sbbs3/main.cpp
    By: Rob Swindell to Git commit to main/sbbs/master on Sun Nov 29 2020 12:31 am

    another unused node and you (or that user) will get an updated configuration. Bots or server recycling
    problems will no longer prevent the sysop or user from getting a current configuration when connecting
    to any node.

    This is one of those instances of giving the sysop what he wants rather than what he asked for. I
    should've done this a long time ago, but the idea just occurred to me. You're welcome. :-)

    This is freaking awesome. Thanks DM!

    |01bobbobbobbob|09bob|03bob|11bob|03bob|09bob|01bobbobbob |01robrobrobrob|09rob|03rob|11rob|03rob|09rob|01robrobrob
    |07

    ---
    þ Synchronet þ Halls of Valhalla =San=Francisco= Happy Holidays
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Dec 6 20:21:13 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/d9ea54258ab2a39b3e71bdcf
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't create a JS "client" object for timed events

    There is no actual TCP-client when a timed event is executing, so don't create one in the JS context when the socket is invalid.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Dec 13 02:00:30 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/0d8ea19e309c6afd80a587c8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Create node#/client.ini for each node client connection

    Paves the way for utilities like umonitor to show client details for node connections (e.g. IP address, hostname, connection duration, etc.)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Dec 19 16:09:15 2020
    https://gitlab.synchro.net/main/sbbs/-/commit/5e46cb0f6cc44b2176c97b0f
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Additional/optional 'mode' argument to global prompt() method

    Defaults to K_EDIT.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 21 19:38:20 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4187942a94aeb8489a4a1371
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix build issue on *nix with the new protected int destroy macros.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 22 00:27:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8fabcdf19acb64f684922f68
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Use the CopyFile() function when moving files.

    This function is the fastest file-copy method (or should be), but does not have any progress indication.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Mar 5 20:41:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/f4d33f43cc1326150c82e100
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Don't leave the logged event code as "DAILY" after daily events run

    I noticed "DAILY ... Semaphore signaled" in the event thread log output. Now fixed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Mar 15 00:16:56 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5bb4bcc4a60fd2b03ca2efe8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Increase flush write timeout for SSH.

    During YModem-G transfers, the previous 5-second timeout was
    exceeded.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Mar 15 00:52:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/ffb202237f4fde4d79c407a2
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Changing timeout didn't help. Use PopData of zero bytes to rekey...

    This issue may actually be a rekey issue, to clear this, we need
    to call cryptPopData(), but we can pop zero bytes.

    In this case, re-try the flush.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Mar 15 01:11:15 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/2e1cedadc9d93f2810cd9571
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Revert the last changes.

    Something weird is happening to the cryptlib session when SZ sends
    a lot of data... no real clues left.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Wed Mar 31 16:51:17 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/8f0ae86b415a9e079ed1acfc
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix error in last commit.

    Looks like I was partially restoring old code before I stopped.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 15:13:57 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9c5205aa056dc04b0dd8e13e
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    ftell() can return negative, deal

    CID 33232

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Apr 5 01:13:34 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/59bb0c3da6774ae5f9b405b1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Spaces -> Tabs

    Tabs are the shit.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Apr 5 01:15:12 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/9b14bb14cb24fb209a882e82
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    MOAR!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Mon Apr 5 01:25:04 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/5bf7a8475ec4aa7ee88c37e3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    EVN MR!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed May 12 22:53:45 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/3202b477e52faa34e6fa5666
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Attempt to resolve "!ERROR 11 receiving from socket" reported by plt

    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> append key into keybuf: 4E (N)
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> Executing external: /sbbs/exec/sexyz 14 -Telnet sz /mnt/disk1/dl/COCO/AGI/agi-xmas.zip
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: Synchronet External X/Y/ZMODEM v3.0 master/23b741a1c Copyright Rob Swindell
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File skipped by receiver
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !File Skipped <plt> May 13 00:39:40 sbbs synchronet: term Node 1 <plt> sexyz: !0 Aborting Transfer (Sending ZABORT)
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 !ERROR 11 receiving from socket 14
    <plt> May 13 00:39:40 sbbs synchronet: term Node 1 input thread terminated (received 365 bytes in 35 blocks)

    Not sure why this isn't happening for other sysops - perhaps plt was spying on the node?

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun May 16 16:47:09 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/4a705a4667fea6e699d7965a
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log local address in passthru connection failure

    Altere reported via IRC:
    !ERROR -1 (113) connecting to passthru socket

    It might be helpful to know the address the passthru socket is bound to and the connection is being attempted on, so log that with the error.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun May 16 18:13:51 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/54de9ce32a60a3ec38fcd41d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix the printf format for the "ERROR ... connecting to passthru socket"

    Was passing the address string twice, so the port appeared as an invalid number.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Jun 8 21:59:20 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/31149a208abdd6cf12317cb4
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Always use rename() on *nix when mv() is called with copy=FALSE

    This should fix issue #272 reported by Ragnarok. Not the libarchive error part, but the second (mv) CopyFile error part.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Jun 11 11:29:25 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/b093e0c714828fe1aae5a3f9
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix newly-introduced (but likely harmless) bug in mv()

    Thanks Coverity! (CID 332340)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Jan 19 01:31:29 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/26bc17de8f51f3e34977bd82
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Add run-time check for non-terminating/unsafe snprintf() function

    Only in debug builds.
    If this check fails, then we may be producing/using potentially un-terminated strings and need to do something about that. By default, xpdev/genwrap.h redefines snprintf() as safe_snprintf(), so this check *should* always succeed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 6 02:34:55 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/dbf0a87ad95f01a4f88a324d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Clear mouse hot spots (if any) before hanging up.

    <nelgin> Ah, here's a good one. If I ssh to my bbs server, then ssh to my bbs, do whatever then /O to logout, when I left click in the putty window I get "0;98;20M0;98;20m and stuff like that. I have to run reset to get it working properly.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Feb 21 15:59:31 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/b269b65ad5d09814abbbff51
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Refactor timed-event and QWKnet call-out scheduling

    Reduced probably the biggest if() conditionals in sbbs to a single line by breaking the "time to run" logic into separate functions and sharing those functions between both QWKnet and timed-event scheduling. There was no actual problem with this code/logic, it was just very difficult to read and understand and step-through with a debugger and understand why or why not an event might run under different configurations and circumstances.

    Also removed the PostLink network call-out logic. pnet.dab is no longer read and written-to and if you happened to have any PostLink hubs configured (how?!?), they'll no longer be "polled". This is the only functional change unless I did something wrong in the process.

    One thing I noticed and contemplated, the current time is not queried between consecutive timed-event scheduling/execution. It's possible that an executed event can take a long time and impact the criteria for the next timed event. The events are checked for scheduling every few seconds, so I can't really think of a big down-side to the current design (apparently intended to reduce unnecessary querying of the current date/time), so I didn't do anything to change that. Just something I noticed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Wed Feb 23 23:25:45 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/eb4fa76ca9635a48ea2c103f
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Delete dead code

    CID 174474

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Feb 27 21:50:18 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/80de2727ae620ef4e770c3c6
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower the "SSH session establishment failed" log msg level

    from NOTICE to INFO, per Nelgin

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:07 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/b9e78bdf93e4d9b3e7608e4d
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Batch download queue not cleared upon packed QWK packet

    Before the "new filebase" merge of 2021, a user's batch download queue would be cleared when a QWK packet was successfully packed for them via the event thread (i.e. triggered via semaphore file). That was lost in the new filebase change (the batch download queue would not be cleared) - caught by Coverity (CID 350336).

    It appears pre-packed QWK packets never cleared the batch download queue (does anyone actually use this feature in this day and age?) - fixed.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 3 16:45:56 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/eb7e6bbfaa15e42dc18239b3
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix CID 174378: Argument cannot be negative

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Mar 13 00:26:38 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/570f6f5ebcdb52a8c359dfc8
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix CID 319133: Unchecked return value

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 31 00:11:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/141112e104ee22552140d82f
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower level of new "Logoff time <= logon time" log message

    ... from ERROR to WARNING, but log the human-readable logon time too.

    This condition can easily happen if the system clock is corrected (e.g. a few seconds via NTP adjustment) during a quick connect/disconnect.

    Don't call logoffstats() unless a user actually successfully logged-in. I don't think sysops actually want all the time bots sit at the logon prompt counted as "time online" in their stats anyway.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 31 18:59:38 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3ff572429ea30b11fb33d6b1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    When auto-deleting inactive users, log their real name too.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Apr 14 14:59:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/cfd62425cd0c93e927989897
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Address new GCC warning instance

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Apr 15 16:09:33 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/f4b595c0a4726853510a083c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Truncate node.dab to correct size when initializing any sbbs_t instance

    Fixes issue #395

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jul 10 14:26:22 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/d2acbe52c3615ab8bfb45837
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Eliminate newly-unused variable: addr_str

    Fixes issue #421

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Sep 16 16:46:29 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/b91acb61c474ed71a1fa3a2e
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix crash when cleanup() was called twice in a row, e.g. load_cfg failure

    Need to nullify the xpms after destroying/freeing (as is done in other
    servers already).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 19 13:20:40 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/d1f4767a9597b659d7996e83
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Correct node number *always* before clearning NODE_RRUN [R] status flag

    If nodeX/node.cnf has the wrong node number, the [R] flag would be cleared from the wrong node upon automatic configuration reload. This likely fixes the issue that Keyop is reporting in #synchronet

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Dec 29 13:54:23 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/56d1e7fe4b3c6bf6176e4406
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Output snappiness improvements.

    When the system checks for an incoming byte, if there's any pending
    output, send it immediately, bypassing the outbuf highwater mark.

    This allows the final non-full packet to be sent without waiting
    for the OutbufDrainTimeout (default 10ms), and makes a big difference
    when doing a large number of ANSI queries (send an ANSI code, wait
    for a response). There's a small but noticable placebo effect as
    well that makes everything feel smoother.

    This commit also cleans up the output thread where it pulls from
    the ring buffer into the linear buffer to take advantage of the new
    event-based ring buffers. Much easier to read now.

    Speaking of easier to read, this also includes some whitespace
    fixups.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Dec 29 17:14:12 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/fe78b9895edde6d8217c2dc1
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Call RingBufRead() when avail == 0 to reset events

    If something else sets these events, and they never get cleared,
    this will fall into a tight loop.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Dec 29 18:49:37 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/e379967ced1c8dc936090ff2
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Move some lines around to clamp sbbs->outbuf.highwater_mark at IO_THREAD_BUF_SIZE

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Dec 29 19:36:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/dfc4e9320299020943ea640c
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Eliminate the global 'sbbs' here, was masking bugs

    I'm not sure what purpose this global variable once had, but it wasn't needed now and it was masking copy/paste issues in some of the sbbs_t methods in this file. Just make an 'sbbs' local to bbs_thread(), since there's where it's legit-used.

    FYI: All the Cryptlib-SSH macros assume there's an 'sbbs' in scope.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Dec 29 19:36:44 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/020382e9d42c92aa8da3324f
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Add sendsocket() result checking/error-logging to send_telnet_cmd()

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Dec 29 19:38:24 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/993518491b6ec81ed2a83151
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix gcc warnings in previous commit: don't bother with [s]size_t here

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Dec 30 01:16:32 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/d1e32893f4adc36ed88f69a0
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Lower log level of send_telnet_cmd() send failure (to debug level)

    As apparently these happen a lot when a client disconnects right
    away after connecting.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Fri Dec 30 03:37:24 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/2eea219da85b0b8e205900ba
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Clean-up the logging around the auto-tuned outbuf highwater mark

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 1 20:28:10 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/f169a52fa7454842a6540423
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Remove accidentally added debug line with no effect.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Jan 3 21:41:33 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fec7f7de961c102b4052e255
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Include time used (HH:MM:SS) in node#/laston mqtt msg

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jul 11 19:17:01 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6713d10cb1f9e44d1cb8a9e6
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix incorrect 'socket' value for new (highwater) log message

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jul 11 19:17:01 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/06f6b07ddbc0ba9f7d66f5c5
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Eliminate large-scoped 'i' variable in bbs_thread()

    This is just a code quality (readability) improvement. No functional change.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jul 11 19:29:21 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/59e30dda6bb683b9c1a97298
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Fix *nix build

    We removed the large-scope 'i', but didn't update the Unix-only blocks of code (dealing with UNIX domain spy sockets).

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Jul 11 19:39:16 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/bca9510b25f790f84f59545a
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Include current node number intead of socket descriptor in highwater log msg

    looks better, more consistent with the log messages before/after it.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Aug 3 19:58:06 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c03ed4b9ce042d5651575e18
    Modified Files:
    src/sbbs3/main.cpp
    Log Message:
    Log a warning if any socket inactivity max durations are shorter/equal to ...

    to the getkey inactivity timeout.

    By setting a socket timeout shorter or equal to the getkey timeout, the getkey timeout effectively does nothing.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net