• src/sbbs3/js_msgbase.c

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Wed Mar 29 12:52:05 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/fe14b001e563ea3b10c82cbf
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    MsgBase.save_msg() throw an exception when an empty recipient list is provided

    ... rather than just return false.

    This will make debugging this type of issue much easier in the future. sendmail.js was allowing empty recipient_list array arguments and the MsgBase .status was 0 and .error just an emtpy string - unhelpful.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Sun May 7 23:22:44 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d5e8981d0631d766b37a061f
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    MsgBase.save_msg() docs says only one argument is required

    So use js_argc() to report an error if there's fewer than 1 argument, but
    don't just fail silently when 2 arguments are provided.

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon May 8 18:07:50 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/de41e1b7a314ceaacfb6c321
    Modified Files:
    src/sbbs3/js_msgbase.c
    Log Message:
    Use js_argc() to generate the helpful exception when insufficient args used

    ... rather than just failing silently with a special return value
    (e.g. false).

    ---
    Synchronet Vertrauen Home of Synchronet [vert/cvs/bbs].synchro.net