1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/chksmb.c

    From Rob Swindell@VERT to Git commit to sbbs/master on Sat Sep 26 13:38:58 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/17b7aee1b051c3b366c5dfa6
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Use smb_msg_type() to double-check the header type against attribute flags.

    The inferred message type should match the stored message type. Confirm that.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 25 19:36:21 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/35f764eef674aaeb7ce528b2
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Always report the total LZH compressed messages

    This looks like a 20-year-old copy/paste bug. CID 33168.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Mar 1 22:43:08 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/faa31747a860b290922393c3
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Zero-initialize smb before using

    Addresses CID 350318

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Jun 4 20:26:40 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3ccd8ef8b20ce61a37fe4d5a
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Fix copy/paste bug discovered/reported by gcc version 11.2.0

    ... in debug print statement (MD5 hast decoded/printed as SHA-1 hash).

    Reported by Nelgin running gcc version 11.2.0 (Ubuntu 11.2.0-19ubuntu1)

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Sep 9 18:29:23 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0fd380f86a5eaa05467f08ea
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Don't check header fields of deleted messages for control characters

    ... related to issue #786.

    Also, don't check for a message-ID if the message-type does not match the expected message type ("type mismatch").

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Sep 13 20:08:11 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/5f0fb1c7455a7345da04cf6d
    Modified Files:
    src/sbbs3/chksmb.c
    Log Message:
    Perform filename checks (index versus header fields) on filebases

    I was able to corrupt a filebase using fileman.js, renaming a file
    (the filename in the index as viewed with 'smbutil x' did not match
    the filename listed with 'smbutil l') - yet, chksmb reported no errors
    with the filebase.

    Now chksmb will detect that type of corruption.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net