• src/sbbs3/putmsg.cpp

    From Rob Swindell@VERT to Git commit to sbbs/master on Thu Oct 8 20:12:37 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9919c23e8e52f5b7bb9a79f4
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    I do wonder if the outchar_esc value check should be == here instead of >=, but I'm not familiar with the string and SOS states. I wonder if any display files sent from the BBS would ever include those sequences.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Hatton@VERT/THRCORN to Rob Swindell on Fri Oct 9 00:31:00 2020
    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no
    longer pass-through the ANSI sequence ESC[c (found in some corrupted
    ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this
    will stimulate a (unwanted) response from the client.

    Thank you!

    Hatton


    ... DalekDOS v(overflow): (I)Obey (V)ision impaired (E)xterminate
    --- MultiMail/Win v0.52
    þ Synchronet þ Three Corners and Beyond! http://3corners.us
  • From Digital Man@VERT to Hatton on Thu Oct 8 22:18:21 2020
    Re: Re: src/sbbs3/putmsg.cpp
    By: Hatton to Rob Swindell on Fri Oct 09 2020 12:31 am

    Rob Swindell wrote to Git commit to sbbs/master <=-

    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't pass-through ANSI Device Attributes (DA) requests

    putmsg(), used to display messages and display/menu files, will no longer pass-through the ANSI sequence ESC[c (found in some corrupted ANSI posts to fsxNet->FSX_BOT echo) to the client terminal since this will stimulate a (unwanted) response from the client.

    Thank you!

    Sure. There are likely more sequences we might want to filter out of ANSI-encoded messages (or whitelist only the ones we *do* want to pass-through), but this'll work for now.

    digital man

    Synchronet "Real Fact" #95:
    Synchronet v3.15b was released in October of 2011 (5 years after v3.14a). Norco, CA WX: 62.8øF, 84.0% humidity, 3 mph ESE wind, 0.00 inches rain/24hrs

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Mon Nov 2 02:30:29 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/93dc3f128816d1ddb24b6cab
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Allow punctuation characters on either side of the markup tags

    So you can do stuff (*like this*).

    Also, we don't need to heavily scrutinize the closing tag when we come upon it because we already determined it was valid before we accepted the opening tag/character.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Nov 8 13:15:19 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/9090d40fc64d791bc7dd37a3
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't support back-to-back marks in markup parsing

    Addresses false-positive matches in URLs (e.g. https://minftn.net/) where the second slash was being interpreted as a the beginning of an italic markup.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sun Nov 8 15:57:40 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/515b0854e73a3f2ff5fb89a5
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Don't allow adjacent marked-up text.

    This allows us to ignore markup codes in a string like: "/sbbs/ctrl/*cnf*"

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 23 01:08:25 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/09a32c0dad9f896893f2845b
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Basic PETSCII output column/line counting in putmsg()

    When printing a PETSCII Sequence (.seq) file, count the lines/rows and columns similar to how we would if we were using outchar() (but we don't, we use the lower-level outcom() to bypass any translations).

    This is related to issue #325:
    PETSCII seq files seem to display just fine, the problem I saw was with the auto-pausing (e.g. before a screen-clear) after displaying them.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 23 12:29:13 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/ca9bac807ce2a4721d6c17cb
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Add case fall-through comment

    To address CID 345626

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Jan 23 12:48:34 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/77c7a2933e156cd2f0e61619
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Address GCC warnings: case label value exceeds maximum value for type

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 10 00:24:49 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/3ca2c14ff9a87674c8e8808b
    Modified Files:
    src/sbbs3/putmsg.cpp
    Log Message:
    Fix Clang warnings.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net